netdev - Re: [patch iproute2 v2 repost 1/3] tc_filter: add support for chain index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170526171137.0acccbc5@xeon-e3>
Date:   Fri, 26 May 2017 17:11:37 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
        davem@...emloft.net, jhs@...atatu.com, xiyou.wangcong@...il.com,
        dsa@...ulusnetworks.com, edumazet@...gle.com,
        alexander.h.duyck@...el.com, simon.horman@...ronome.com,
        mlxsw@...lanox.com
Subject: Re: [patch iproute2 v2 repost 1/3] tc_filter: add support for chain
 index

On Fri, 26 May 2017 21:48:05 +0200
Daniel Borkmann <daniel@...earbox.net> wrote:

> On 05/23/2017 03:40 PM, Jiri Pirko wrote:
> > Mon, May 22, 2017 at 10:33:15PM CEST, stephen@...workplumber.org wrote:  
> [...]
> >> Applied to net-next branch of iproute2  
> >
> > Looks like you missed the uapi part:
> >
> >      CC       tc_filter.o
> > tc_filter.c: In function ‘tc_filter_modify’:
> > tc_filter.c:159:34: error: ‘TCA_CHAIN’ undeclared (first use in this function)
> >     addattr32(&req.n, sizeof(req), TCA_CHAIN, chain_index);
> >                                    ^~~~~~~~~  
> 
> Looks like still unresolved in the iproute2 -net-next branch ...

On the net-next branch include/linux/rtnetlink.h now has TCA_CHAIN, and everything
builds fine.  You may have local changes or be using different includes

$ git grep TCA_CHAIN
include/linux/rtnetlink.h:      TCA_CHAIN,
tc/tc_filter.c:         addattr32(&req.n, sizeof(req), TCA_CHAIN, chain_index);
tc/tc_filter.c: if (tb[TCA_CHAIN]) {
tc/tc_filter.c:         __u32 chain_index = rta_getattr_u32(tb[TCA_CHAIN]);
tc/tc_filter.c:         addattr32(&req.n, sizeof(req), TCA_CHAIN, chain_index);
tc/tc_filter.c:         addattr32(&req.n, sizeof(req), TCA_CHAIN, chain_index);