netdev - Re: [PATCH net-next] net: stmmac: use correct pointer when printing normal descriptor ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfwEGZ9m1_h=JSq4zmX0wy7Qgd-1uSVy3R0KfcSX09p1A@mail.gmail.com>
Date:   Sun, 28 May 2017 00:59:37 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Niklas Cassel <niklas.cassel@...s.com>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Niklas Cassel <niklass@...s.com>,
        netdev <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: stmmac: use correct pointer when printing
 normal descriptor ring

On Tue, May 9, 2017 at 7:52 PM, Niklas Cassel <niklas.cassel@...s.com> wrote:
> From: Niklas Cassel <niklas.cassel@...s.com>

Commit message?

>                         seq_printf(seq, "%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n",
> -                                  i, (unsigned int)virt_to_phys(ep),
> +                                  i, (unsigned int)virt_to_phys(p),

There is should not be casting. Pointer might be 64-bit, thus %pap
must be used instead with a reference to the physical address.

>                                    le32_to_cpu(p->des0), le32_to_cpu(p->des1),
>                                    le32_to_cpu(p->des2), le32_to_cpu(p->des3));
>                         p++;

-- 
With Best Regards,
Andy Shevchenko