lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20170527.195840.838540630181121791.davem@davemloft.net> Date: Sat, 27 May 2017 19:58:40 -0400 (EDT) From: David Miller <davem@...emloft.net> To: f.fainelli@...il.com Cc: netdev@...r.kernel.org, andrew@...n.ch, Woojung.Huh@...rochip.com Subject: Re: [PATCH net-next v2] net: phy: Relax error checking on sysfs_create_link() From: Florian Fainelli <f.fainelli@...il.com> Date: Sat, 27 May 2017 10:42:25 -0700 > Some Ethernet drivers will attach/connect to a PHY device before calling > register_netdevice() which is responsible for calling netdev_register_kobject() > which would do the network device's kobject initialization. In such a case, > sysfs_create_link() would return -ENOENT because the network device's kobject > is not ready yet, and we would fail to connect to the PHY device. > > In order to keep things simple and symetrical, we just take the success path as > indicative of the ability to access the network device's kobject, and create > the second link if that's the case. > > Fixes: 5568363f0cb3 ("net: phy: Create sysfs reciprocal links for attached_dev/phydev") > Reported-by: Woojung Hung <Woojung.Huh@...rochip.com> > Signed-off-by: Florian Fainelli <f.fainelli@...il.com> > --- > Changes in v2: > - make sure phydev->sysfs_links is set to false before setting again Applied, thanks Florian.
Powered by blists - more mailing lists