netdev - Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+PODjoZpYLVKCXveUGvu8MXX4YVmE-bKm241o_3OT3P5pkieQ@mail.gmail.com>
Date:   Mon, 29 May 2017 13:44:15 +0300
From:   Andrey Melnikov <temnota.am@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for
 Mediatek MT7530 switch

2017-05-26 8:54 GMT+03:00 Florian Fainelli <f.fainelli@...il.com>:
> On May 24, 2017 4:17:39 AM PDT, "Andrey Jr. Melnikov" <temnota.am@...il.com> wrote:
>>In gmane.linux.kernel sean.wang@...iatek.com wrote:
>>> From: Sean Wang <sean.wang@...iatek.com>
>>
>>> MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on
>>> Mediatek router platforms such as MT7623A or MT7623N platform which
>>> includes 7-port Gigabit Ethernet MAC and 5-port Gigabit Ethernet PHY.
>>> Among these ports, The port from 0 to 4 are the user ports connecting
>>> with the remote devices while the port 5 and 6 are the CPU ports
>>> connecting into Mediatek Ethernet GMAC.
>>
>>> For port 6, it can communicate with the CPU via Mediatek Ethernet
>>GMAC
>>> through either the TRGMII or RGMII which could be controlled by
>>phy-mode
>>> in the dt-bindings to specify which mode is preferred to use. And for
>>> port 5, only RGMII can be specified. However, currently, only port 6
>>is
>>> being supported in this DSA driver.
>>
>>> The driver is made with the reference to qca8k and other existing DSA
>>> driver. The most of the essential callbacks of the DSA are already
>>> support in the driver, including tag insert for user port
>>distinguishing,
>>> port control, bridge offloading, STP setup and ethtool operation to
>>allow
>>> DSA to model each user port into a standalone netdevice as the other
>>DSA
>>> driver had done.
>>
>>What about JUMBO frames and large MTU support? devlink support?
>
> We don't have a ndo_change_mtu callback implemented for DSA network devices but that is probably how we should do it.
> Regarding devlink, Andrew added basic support for it but unlike mlxsw it is currently of mild interest. Do you have something specific in mind with devlink?

I want to see each ports behind the bridge as independent ethernet
devices. If I understand RTFM only devlink may expose this
configuration.