netdev - Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170529160252.GA27550@obsidianresearch.com>
Date:   Mon, 29 May 2017 10:02:52 -0600
From:   Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:     Ilan Tayari <ilant@...lanox.com>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Saeed Mahameed <saeedm@....mellanox.co.il>,
        "David S. Miller" <davem@...emloft.net>,
        Doug Ledford <dledford@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "jsorensen@...com" <jsorensen@...com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        Alan Tull <atull@...nsource.altera.com>,
        "yi1.li@...ux.intel.com" <yi1.li@...ux.intel.com>,
        Boris Pismenny <borisp@...lanox.com>
Subject: Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

On Mon, May 29, 2017 at 03:58:33PM +0000, Ilan Tayari wrote:
> > From: Jason Gunthorpe [mailto:jgunthorpe@...idianresearch.com]
> > Subject: Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova
> > 
> > On Sun, May 28, 2017 at 07:22:27AM +0000, Ilan Tayari wrote:
> > 
> > > This is neither PCI-bar mapped, nor mailbox command.
> > > The FPGA is indeed a bump-on-the-wire.
> > > (It has I2C to the CX4 chip, but that is for debug purposes, and too
> > slow
> > > to perform real programming)
> > 
> > Wait.. So if it truely has nothing to do with the existing mellanox
> > driver, then nothing more than the fpga loader should be in the mlx5
> > directory?
> 
> True, except in specific cases when the FPGA may mangle the packets in
> a way that the netdevice configures, and the driver needs to adapt the
> data path.

> Such is the case of IPSec and TLS offloads.
> Those are tied to the mlx5 Ethernet driver (isolated with a kconfig).

But there is nothing stopping this sort of FPGA mangling logic being
downstream of any NIC, Mellanox is just the first to do this.

I think you'd be better to add something to the net stack to model
this post-nic mangling hardware, than trying to hide it in a driver.

Jason