netdev - Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170530165025.GA30766@lunn.ch>
Date:   Tue, 30 May 2017 18:50:25 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions

On Mon, May 29, 2017 at 11:06:51PM +0200, Arnd Bergmann wrote:
> On Mon, May 29, 2017 at 5:30 PM, Andrew Lunn <andrew@...n.ch> wrote:
> > On Mon, May 29, 2017 at 02:56:01PM +0200, Arnd Bergmann wrote:
> >> 'static' was not enough, the helpers must be 'static inline'
> >>
> >> net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function]
> >> net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]
> >>
> >> Fixes: c21fbe29f858 ("net: dsa: mv88e6xxx: Add missing static to stub functions")
> >> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> >
> > Hi Arnd
> >
> > Dave merged my fix yesterday.
> 
> Hi Andrew,
> 
> The only commit I see from you in the net/master branch is the partial fix
> I referenced in the 'fixes' line (c21fbe29f858), from all I can tell, my fix is
> still needed on top. Can you check again?

Hi Arnd

Yes, you are correct. Adding the static was enough to stop the 0-day
warnings, but they should also inline.

	  Andrew