netdev - Re: [PATCH net-next 6/7] bnxt_en: Implement xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 May 2017 20:49:19 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     "Mintz, Yuval" <Yuval.Mintz@...ium.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 6/7] bnxt_en: Implement xmit_more.

On Mon, May 29, 2017 at 8:28 PM, Mintz, Yuval <Yuval.Mintz@...ium.com> wrote:
>
>> -       bnxt_db_write(bp, txr->tx_doorbell, DB_KEY_TX | prod);
>> +       if (!skb->xmit_more)
>> +               bnxt_db_write(bp, txr->tx_doorbell, DB_KEY_TX | prod);
>
> DQL can prevent you from getting the xmit_more marked SKB,
> so you should probably also check for netif_xmit_stopped().

Good point.  Thanks.