netdev - Re: [PATCH v3 0/6] stmmac: pci: Refactor DMI probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcGNr78mfGgtrKuZJtLppv=rAJ4Bxejcec3MhnC6ejSjQ@mail.gmail.com>
Date:   Tue, 30 May 2017 21:48:05 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jan Kiszka <jan.kiszka@...mens.com>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 0/6] stmmac: pci: Refactor DMI probing

On Tue, May 30, 2017 at 10:33 AM, Jan Kiszka <jan.kiszka@...mens.com> wrote:
> Some cleanups of the way we probe DMI platforms in the driver. Reduces
> a bit of open-coding and makes the logic easier reusable for any
> potential DMI platform != Quark.
>
> Tested on IOT2000 and Galileo Gen2.

So, for patches 1-4,
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

I'm not convinced that patch 6 is needed, so, my vote is not to include it.

Patch 5 I would like to review later. Main problem to me is {-1, -1}.
It looks non-standard and feels not good. I'll try to think on the
solution.

> Jan Kiszka (6):
>   stmmac: pci: Make stmmac_pci_info structure constant
>   stmmac: pci: Use stmmac_pci_info for all devices
>   stmmac: pci: Make stmmac_pci_find_phy_addr truly generic
>   stmmac: pci: Select quark_pci_dmi_data from quark_default_data
>   stmmac: pci: Use dmi_system_id table for retrieving PHY addresses
>   stmmac: pci: Remove setup handler indirection via stmmac_pci_info

-- 
With Best Regards,
Andy Shevchenko