lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <e172a668-eae0-4d94-4e59-40cbc100418e@mellanox.com> Date: Tue, 30 May 2017 12:28:26 +0300 From: Yotam Gigi <yotamg@...lanox.com> To: Arnd Bergmann <arnd@...db.de> CC: "David S. Miller" <davem@...emloft.net>, Ido Schimmel <idosch@...lanox.com>, Jiri Pirko <jiri@...lanox.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next] net/mlxfw: select CONFIG_XZ_DEC On 05/30/2017 12:26 PM, Arnd Bergmann wrote: > The new mlxfw code fails to build without the xz library: > > drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.o: In function `mlxfw_mfa2_xz_dec_run': > :(.text.mlxfw_mfa2_xz_dec_run+0x8): undefined reference to `xz_dec_run' > drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.o: In function `mlxfw_mfa2_file_component_get': > :(.text.mlxfw_mfa2_file_component_get+0x218): undefined reference to `xz_dec_init' > :(.text.mlxfw_mfa2_file_component_get+0x2c0): undefined reference to `xz_dec_end' > > This adds a Kconfig 'select' statement for it, which is also what > the other user of that library has. > > Fixes: 410ed13cae39 ("Add the mlxfw module for Mellanox firmware flash process") > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > drivers/net/ethernet/mellanox/mlxfw/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/mellanox/mlxfw/Kconfig b/drivers/net/ethernet/mellanox/mlxfw/Kconfig > index 56b60ac7bc34..2b21af8a2b1d 100644 > --- a/drivers/net/ethernet/mellanox/mlxfw/Kconfig > +++ b/drivers/net/ethernet/mellanox/mlxfw/Kconfig > @@ -4,3 +4,4 @@ > > config MLXFW > tristate "mlxfw" if COMPILE_TEST > + select XZ_DEC Thanks! Acked-by: Yotam Gigi <yotamg@...lanox.com>
Powered by blists - more mailing lists