netdev - Re: [PATCH net-next] cxgb4: FW upgrade fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3970fd69-a6fd-c0ba-6bf0-31fb3f54f1c1@cogentembedded.com>
Date:   Tue, 30 May 2017 12:39:45 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Ganesh Goudar <ganeshgr@...lsio.com>, netdev@...r.kernel.org,
        davem@...emloft.net
Cc:     nirranjan@...lsio.com, Arjun Vynipadath <arjun@...lsio.com>,
        Casey Leedom <leedom@...lsio.com>
Subject: Re: [PATCH net-next] cxgb4: FW upgrade fixes

Hello!

On 5/30/2017 10:15 AM, Ganesh Goudar wrote:

> From: Arjun Vynipadath <arjun@...lsio.com>
>
> Disable FW_OK flags while flashing Firmware. This will help to fix any
> potential mailbox timeouts during Firmware flash.
>
> Grab new devlog parameters after Firmware restart. When we FLASH new
> Firmware onto an adapter, the new Firmware may have the Firmware Device Log
> located at a different memory address or have a different size for it.
>
> Signed-off-by: Arjun Vynipadath <arjun@...lsio.com>
> Signed-off-by: Casey Leedom <leedom@...lsio.com>
> Signed-off-by: Ganesh Goudar <ganeshgr@...lsio.com>
> ---
>  drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 21 ++++++++++++++++++---
>  1 file changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
> index b97ce4a..325f98c 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
> @@ -6288,13 +6288,18 @@ int t4_fw_upgrade(struct adapter *adap, unsigned int mbox,
>  	if (!t4_fw_matches_chip(adap, fw_hdr))
>  		return -EINVAL;
>
> +	/* Disable FW_OK flags so that mbox commands with FW_OK flags check
> +	 * wont be send when we are flashing FW.

    Sent.

[...]

MBR, Sergei