netdev - Re: [PATCH net-next 6/7] bnxt_en: Implement xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BLUPR0701MB20040DED85E53FEFE75C591E8DF00@BLUPR0701MB2004.namprd07.prod.outlook.com>
Date:   Tue, 30 May 2017 03:28:24 +0000
From:   "Mintz, Yuval" <Yuval.Mintz@...ium.com>
To:     Michael Chan <michael.chan@...adcom.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 6/7] bnxt_en: Implement xmit_more.


> -       bnxt_db_write(bp, txr->tx_doorbell, DB_KEY_TX | prod);
> +       if (!skb->xmit_more)
> +               bnxt_db_write(bp, txr->tx_doorbell, DB_KEY_TX | prod);

DQL can prevent you from getting the xmit_more marked SKB,
so you should probably also check for netif_xmit_stopped().