netdev - Re: [PATCH net-next] net: ndisc.c: reduce size of __ndisc_fill_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1496115666.2618.9.camel@perches.com>
Date:   Mon, 29 May 2017 20:41:06 -0700
From:   Joe Perches <joe@...ches.com>
To:     David Miller <davem@...emloft.net>, cugyly@....com
Cc:     netdev@...r.kernel.org, dsahern@...il.com,
        Linyu.Yuan@...atel-sbell.com.cn
Subject: Re: [PATCH net-next] net: ndisc.c: reduce size of
 __ndisc_fill_addr_option()

On Mon, 2017-05-29 at 23:30 -0400, David Miller wrote:
> From: yuan linyu <cugyly@....com>
> Date: Sat, 27 May 2017 06:00:52 +0800
> 
> > From: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>
> > 
> > Signed-off-by: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>
> 
> Applied, thanks.

OK, but is it really safe though?

Could "space" (an int) ever be negative after
subtracting "pad" and "data_len"?