netdev - Re: [PATCH net] cxgb4: avoid crash on PCI error recovery path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170530.121630.85776802788069421.davem@davemloft.net>
Date:   Tue, 30 May 2017 12:16:30 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     gpiccoli@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, muvic@...ux.vnet.ibm.com,
        porcusbr@...il.com, ganeshgr@...lsio.com, hariprasad@...lsio.com
Subject: Re: [PATCH net] cxgb4: avoid crash on PCI error recovery path

From: "Guilherme G. Piccoli" <gpiccoli@...ux.vnet.ibm.com>
Date: Sun, 28 May 2017 23:07:01 -0300

> During PCI error recovery process, specifically on eeh_err_detected()
> we might have a NULL netdev struct, hence a direct dereference will
> lead to a kernel oops. This was observed with latest upstream kernel
> (v4.12-rc2) on Chelsio adapter T422-CR in PowerPC machines.
> 
> This patch checks for NULL pointer and avoids the crash, both in
> eeh_err_detected() and eeh_resume(). Also, we avoid to trigger
> a fatal error or to try disabling interrupts on FW during PCI
> error recovery, because: (a) driver might not be able to accurately
> access PCI regions in this case, and (b) trigger a fatal error
> _during_ the recovery steps is a mistake that could prevent the
> recovery path to complete successfully.
> 
> Reported-by: Harsha Thyagaraja <hathyaga@...ibm.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@...ux.vnet.ibm.com>

Applied, thanks.