netdev - Re: [PATCH net-next 1/4] net/flow_dissector: add support for dissection of misc ip header fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170530.121800.676375959648055594.davem@davemloft.net>
Date:   Tue, 30 May 2017 12:18:00 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tom@...bertland.com
Cc:     jiri@...nulli.us, gerlitz.or@...il.com, ogerlitz@...lanox.com,
        netdev@...r.kernel.org, saeedm@...lanox.com, roid@...lanox.com,
        paulb@...lanox.com
Subject: Re: [PATCH net-next 1/4] net/flow_dissector: add support for
 dissection of misc ip header fields

From: Tom Herbert <tom@...bertland.com>
Date: Tue, 30 May 2017 09:06:11 -0700

> The commit log does not mention cls_flower. There are no test results
> given for the impact of the patch. There is no description why tos and
> ttl are being added as opposed to id, flags, or IP options for that
> matter.

The top level merge commit explains everything, and since the patches
are grouped together logically, even if you just look at the merge
commit in the GIT tree, it is mentioned.

This has been going on for so long, it's kinda unreasonable for you to
start complaining now.

Thanks.