netdev - Re: [PATCH] tcp: reinitialize MTU probing when setting MSS in a TCP repair

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170531.122948.1070989770678019987.davem@davemloft.net>
Date:   Wed, 31 May 2017 12:29:48 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     douglascs@...hos.com.br
Cc:     netdev@...r.kernel.org, kuznet@....inr.ac.ru, jmorris@...ei.org,
        yoshfuji@...ux-ipv6.org, kaber@...sh.net, xemul@...allels.com
Subject: Re: [PATCH] tcp: reinitialize MTU probing when setting MSS in a
 TCP repair

From: Douglas Caetano dos Santos <douglascs@...hos.com.br>
Date: Fri, 26 May 2017 14:28:00 -0300

> From: Douglas Caetano dos Santos <douglascs@...hos.com.br>
> 
> MTU probing initialization occurred only at connect() and at SYN or
> SYN-ACK reception, but the former sets MSS to either the default or the
> user set value (through TCP_MAXSEG sockopt) and the latter never happens
> with repaired sockets.
> 
> The result was that, with MTU probing enabled and unless TCP_MAXSEG
> sockopt was used before connect(), probing would be stuck at
> tcp_base_mss value until tcp_probe_interval seconds have passed.
> 
> Signed-off-by: Douglas Caetano dos Santos <douglascs@...hos.com.br>

This seems fine to me, as long as you call tcp_mtup_init() after setting
the mss_clamp, whichy you are, everything should be alright.

Applied, thanks.