lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <201706010053.Bl7sLCqr%fengguang.wu@intel.com>
Date:   Thu, 1 Jun 2017 00:56:55 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Sowmini Varadhan <sowmini.varadhan@...cle.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        sowmini.varadhan@...cle.com, davem@...emloft.net,
        stephen@...workplumber.org
Subject: Re: [PATCH net-next] neigh: Really delete an arp/neigh entry on "ip
 neigh delete" or "arp -d"

Hi Sowmini,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Sowmini-Varadhan/neigh-Really-delete-an-arp-neigh-entry-on-ip-neigh-delete-or-arp-d/20170531-235737
config: x86_64-allyesdebian (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/srcu.h:33:0,
                    from include/linux/notifier.h:15,
                    from include/linux/memory_hotplug.h:6,
                    from include/linux/mmzone.h:757,
                    from include/linux/gfp.h:5,
                    from include/linux/slab.h:14,
                    from net//core/neighbour.c:20:
   net//core/neighbour.c: In function 'neigh_del':
   net//core/neighbour.c:130:25: error: 'tbl' undeclared (first use in this function)
           lockdep_is_held(&tbl->lock)));
                            ^
   include/linux/rcupdate.h:637:36: note: in definition of macro 'rcu_assign_pointer'
     uintptr_t _r_a_p__v = (uintptr_t)(v);          \
                                       ^
>> include/linux/rcupdate.h:587:2: note: in expansion of macro 'RCU_LOCKDEP_WARN'
     RCU_LOCKDEP_WARN(!(c), "suspicious rcu_dereference_protected() usage"); \
     ^~~~~~~~~~~~~~~~
>> include/linux/rcupdate.h:751:2: note: in expansion of macro '__rcu_dereference_protected'
     __rcu_dereference_protected((p), (c), __rcu)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> net//core/neighbour.c:129:8: note: in expansion of macro 'rcu_dereference_protected'
           rcu_dereference_protected(n->next,
           ^~~~~~~~~~~~~~~~~~~~~~~~~
>> net//core/neighbour.c:130:8: note: in expansion of macro 'lockdep_is_held'
           lockdep_is_held(&tbl->lock)));
           ^~~~~~~~~~~~~~~
   net//core/neighbour.c:130:25: note: each undeclared identifier is reported only once for each function it appears in
           lockdep_is_held(&tbl->lock)));
                            ^
   include/linux/rcupdate.h:637:36: note: in definition of macro 'rcu_assign_pointer'
     uintptr_t _r_a_p__v = (uintptr_t)(v);          \
                                       ^
>> include/linux/rcupdate.h:587:2: note: in expansion of macro 'RCU_LOCKDEP_WARN'
     RCU_LOCKDEP_WARN(!(c), "suspicious rcu_dereference_protected() usage"); \
     ^~~~~~~~~~~~~~~~
>> include/linux/rcupdate.h:751:2: note: in expansion of macro '__rcu_dereference_protected'
     __rcu_dereference_protected((p), (c), __rcu)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> net//core/neighbour.c:129:8: note: in expansion of macro 'rcu_dereference_protected'
           rcu_dereference_protected(n->next,
           ^~~~~~~~~~~~~~~~~~~~~~~~~
>> net//core/neighbour.c:130:8: note: in expansion of macro 'lockdep_is_held'
           lockdep_is_held(&tbl->lock)));
           ^~~~~~~~~~~~~~~
--
   In file included from include/linux/srcu.h:33:0,
                    from include/linux/notifier.h:15,
                    from include/linux/memory_hotplug.h:6,
                    from include/linux/mmzone.h:757,
                    from include/linux/gfp.h:5,
                    from include/linux/slab.h:14,
                    from net/core/neighbour.c:20:
   net/core/neighbour.c: In function 'neigh_del':
   net/core/neighbour.c:130:25: error: 'tbl' undeclared (first use in this function)
           lockdep_is_held(&tbl->lock)));
                            ^
   include/linux/rcupdate.h:637:36: note: in definition of macro 'rcu_assign_pointer'
     uintptr_t _r_a_p__v = (uintptr_t)(v);          \
                                       ^
>> include/linux/rcupdate.h:587:2: note: in expansion of macro 'RCU_LOCKDEP_WARN'
     RCU_LOCKDEP_WARN(!(c), "suspicious rcu_dereference_protected() usage"); \
     ^~~~~~~~~~~~~~~~
>> include/linux/rcupdate.h:751:2: note: in expansion of macro '__rcu_dereference_protected'
     __rcu_dereference_protected((p), (c), __rcu)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   net/core/neighbour.c:129:8: note: in expansion of macro 'rcu_dereference_protected'
           rcu_dereference_protected(n->next,
           ^~~~~~~~~~~~~~~~~~~~~~~~~
   net/core/neighbour.c:130:8: note: in expansion of macro 'lockdep_is_held'
           lockdep_is_held(&tbl->lock)));
           ^~~~~~~~~~~~~~~
   net/core/neighbour.c:130:25: note: each undeclared identifier is reported only once for each function it appears in
           lockdep_is_held(&tbl->lock)));
                            ^
   include/linux/rcupdate.h:637:36: note: in definition of macro 'rcu_assign_pointer'
     uintptr_t _r_a_p__v = (uintptr_t)(v);          \
                                       ^
>> include/linux/rcupdate.h:587:2: note: in expansion of macro 'RCU_LOCKDEP_WARN'
     RCU_LOCKDEP_WARN(!(c), "suspicious rcu_dereference_protected() usage"); \
     ^~~~~~~~~~~~~~~~
>> include/linux/rcupdate.h:751:2: note: in expansion of macro '__rcu_dereference_protected'
     __rcu_dereference_protected((p), (c), __rcu)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   net/core/neighbour.c:129:8: note: in expansion of macro 'rcu_dereference_protected'
           rcu_dereference_protected(n->next,
           ^~~~~~~~~~~~~~~~~~~~~~~~~
   net/core/neighbour.c:130:8: note: in expansion of macro 'lockdep_is_held'
           lockdep_is_held(&tbl->lock)));
           ^~~~~~~~~~~~~~~

vim +/rcu_dereference_protected +129 net//core/neighbour.c

   123	{
   124		bool retval = false;
   125	
   126		write_lock(&n->lock);
   127		if (atomic_read(&n->refcnt) == 1 && !(n->nud_state & state)) {
   128			rcu_assign_pointer(*np,
 > 129					   rcu_dereference_protected(n->next,
 > 130					   lockdep_is_held(&tbl->lock)));
   131			n->dead = 1;
   132			retval = true;
   133		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (38863 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ