netdev - Re: [PATCH] isdn: Fix a sleep-in-atomic bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170531.143846.1683078095046995517.davem@davemloft.net>
Date:   Wed, 31 May 2017 14:38:46 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     baijiaju1990@....com
Cc:     isdn@...ux-pingi.de, geliangtang@...il.com, keescook@...omium.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] isdn: Fix a sleep-in-atomic bug

From: Jia-Ju Bai <baijiaju1990@....com>
Date: Wed, 31 May 2017 09:40:11 +0800

> The driver may sleep under a spin lock, the function call path is:
> isdn_ppp_mp_receive (acquire the lock)
>   isdn_ppp_mp_reassembly
>     isdn_ppp_push_higher
>       isdn_ppp_decompress
>         isdn_ppp_ccp_reset_trans
>           isdn_ppp_ccp_reset_alloc_state
>             kzalloc(GFP_KERNEL) --> may sleep
> 
> To fixed it, the "GFP_KERNEL" is replaced with "GFP_ATOMIC".
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@....com>

Applied.