netdev - Re: [PATCH net] tcp: disallow cwnd undo when switching congestion control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170531114732.1cfc4d79@xeon-e3>
Date:   Wed, 31 May 2017 11:47:32 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Yuchung Cheng <ycheng@...gle.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, ncardwell@...gle.com,
        edumazet@...gle.com, soheil@...gle.com
Subject: Re: [PATCH net] tcp: disallow cwnd undo when switching congestion
 control

On Wed, 31 May 2017 11:21:27 -0700
Yuchung Cheng <ycheng@...gle.com> wrote:

> When the sender switches its congestion control during loss
> recovery, if the recovery is spurious then it may incorrectly
> revert cwnd and ssthresh to the older values set by a previous
> congestion control. Consider a congestion control (like BBR)
> that does not use ssthresh and keeps it infinite: the connection
> may incorrectly revert cwnd to an infinite value when switching
> from BBR to another congestion control.
> 
> This patch fixes it by disallowing such cwnd undo operation
> upon switching congestion control.  Note that undo_marker
> is not reset s.t. the packets that were incorrectly marked
> lost would be corrected. We only avoid undoing the cwnd in
> tcp_undo_cwnd_reduction().
> 
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

That looks correct. Are there other values of congestion state
that should be reset?