netdev - Re: [PATCH v5 net-next 0/5] dsa: add Microchip KSZ9477 DSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170531185205.GC11230@lunn.ch>
Date:   Wed, 31 May 2017 20:52:05 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     David Miller <davem@...emloft.net>
Cc:     Woojung.Huh@...rochip.com, f.fainelli@...il.com,
        netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v5 net-next 0/5] dsa: add Microchip KSZ9477 DSA driver

On Wed, May 31, 2017 at 02:47:32PM -0400, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Wed, 31 May 2017 14:28:30 -0400 (EDT)
> 
> > From: <Woojung.Huh@...rochip.com>
> > Date: Wed, 31 May 2017 00:00:34 +0000
> > 
> >> From: Woojung Huh <Woojung.Huh@...rochip.com>
> >> 
> >> This series of patches is for Microchip KSZ9477 DSA driver.
> >> KSZ9477 is 7 ports GigE switch with numerous advanced features.
> >> 5 ports are 10/100/1000 Mbps internal PHYs and 2 ports have
> >> Interfaces to SGMII, RGMII, MII or RMII.
> >> 
> >> This patch supports VLAN, MDB, FDB and port mirroring offloads.
> >> 
> >> Welcome reviews and comments from community.
> >> 
> >> Note: Tests are performed on internal development board.
> > 
> > Series applied, thanks.
> 
> Unfortunately, I had to revert, you didn't add MODULE_LICENSE() tags
> to the new drivers.
> 
> WARNING: modpost: missing MODULE_LICENSE() in drivers/net/dsa/microchip/ksz_common.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/net/dsa/microchip/ksz_spi.o
> see include/linux/module.h for more information

Hi Woojung

Humm, it does not mention the GPL in any of the file headers. So it is
unclear to me what license is used on these files.

	Andrew