lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8729016553E3654398EA69218DA29EEF15BB29A7@cnshjmbx02> Date: Wed, 31 May 2017 00:29:05 +0000 From: YUAN Linyu <Linyu.Yuan@...atel-sbell.com.cn> To: David Ahern <dsahern@...il.com>, Joe Perches <joe@...ches.com>, "David Miller" <davem@...emloft.net>, "cugyly@....com" <cugyly@....com> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: RE: [PATCH net-next] net: ndisc.c: reduce size of __ndisc_fill_addr_option() > > -----Original Message----- > > From: David Ahern [mailto:dsahern@...il.com] > > Sent: Tuesday, May 30, 2017 11:42 AM > > To: Joe Perches; David Miller; cugyly@....com > > Cc: netdev@...r.kernel.org; YUAN Linyu > > Subject: Re: [PATCH net-next] net: ndisc.c: reduce size of > > __ndisc_fill_addr_option() > > > > On 5/29/17 9:41 PM, Joe Perches wrote: > > > On Mon, 2017-05-29 at 23:30 -0400, David Miller wrote: > > >> From: yuan linyu <cugyly@....com> > > >> Date: Sat, 27 May 2017 06:00:52 +0800 > > >> > > >>> From: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn> > > >>> > > >>> Signed-off-by: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn> > > >> Applied, thanks. > > > OK, but is it really safe though? > > > > > > Could "space" (an int) ever be negative after > > > subtracting "pad" and "data_len"? > > > > > > > that function should be converted to skb_put_zero once it hits net-next. > I will check it I can't find skb_put_zero
Powered by blists - more mailing lists