lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD0005B27@AcuExch.aculab.com> Date: Wed, 31 May 2017 10:33:50 +0000 From: David Laight <David.Laight@...LAB.COM> To: 'Jakub Kicinski' <jakub.kicinski@...ronome.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> CC: "oss-drivers@...ronome.com" <oss-drivers@...ronome.com> Subject: RE: [PATCH net-next 10/12] nfp: fix print format for ring pointers in ring dumps From: Jakub Kicinski > Sent: 28 May 2017 01:34 > Ring pointers are unsigned. Fix the print formats to avoid > showing users negative values. ... > > - seq_printf(file, "RX[%02d,%02d]: cnt=%d dma=%pad host=%p H_RD=%d H_WR=%d FL_RD=%d FL_WR=%d\n", > + seq_printf(file, "RX[%02d,%02d]: cnt=%u dma=%pad host=%p H_RD=%u H_WR=%u FL_RD=%u FL_WR=%u\n", I can't help feeling that %x might be better here. The wrap points and ring full conditions will be rather more obvious. David
Powered by blists - more mailing lists