netdev - Re: [PATCH net] bnx2x: Fix Multi-Cos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170601.122259.945935496179490442.davem@davemloft.net>
Date:   Thu, 01 Jun 2017 12:22:59 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Yuval.Mintz@...ium.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net] bnx2x: Fix Multi-Cos

From: Yuval Mintz <Yuval.Mintz@...ium.com>
Date: Thu, 1 Jun 2017 15:57:56 +0300

> Apparently multi-cos isn't working for bnx2x quite some time -
> driver implements ndo_select_queue() to allow queue-selection
> for FCoE, but the regular L2 flow would cause it to modulo the
> fallback's result by the number of queues.
> The fallback would return a queue matching the needed tc
> [via __skb_tx_hash()], but since the modulo is by the number of TSS
> queues where number of TCs is not accounted, transmission would always
> be done by a queue configured into using TC0.
> 
> Fixes: ada7c19e6d27 ("bnx2x: use XPS if possible for bnx2x_select_queue instead of pure hash")
> Signed-off-by: Yuval Mintz <Yuval.Mintz@...ium.com>

Applied and queued up for -stable.