netdev - Re: [PATCH net-next] mlxsw: spectrum: Add bridge dependency for spectrum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170601.150700.1560422855112281074.davem@davemloft.net>
Date:   Thu, 01 Jun 2017 15:07:00 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...lanox.com
Cc:     netdev@...r.kernel.org, jiri@...lanox.com,
        nikolay@...ulusnetworks.com, mlxsw@...lanox.com, arnd@...db.de
Subject: Re: [PATCH net-next] mlxsw: spectrum: Add bridge dependency for
 spectrum

From: Ido Schimmel <idosch@...lanox.com>
Date: Wed, 31 May 2017 21:33:42 +0300

> When BRIDGE is a loadable module, MLXSW_SPECTRUM mustn't be built-in:
> 
> drivers/built-in.o: In function `mlxsw_sp_bridge_device_create':
> drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:145: undefined reference to `br_vlan_enabled'
> drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:158: undefined reference to `br_multicast_enabled'
> drivers/built-in.o: In function `mlxsw_sp_dev_rif_type':
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:2972: undefined reference to `br_vlan_enabled'
> drivers/built-in.o: In function `mlxsw_sp_inetaddr_vlan_event':
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:3310: undefined reference to `br_vlan_enabled'
> 
> Add Kconfig dependency to enforce usable configurations.
> 
> Fixes: c57529e1d5d8 ("mlxsw: spectrum: Replace vPorts with Port-VLAN")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reported-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> Tested-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>

Applied, thanks.