netdev - RE: [PATCH net-next 2/2] bpf: Remove the capability check for cgroup skb eBPF program

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8729016553E3654398EA69218DA29EEF15BB37ED@cnshjmbx02>
Date:   Thu, 1 Jun 2017 00:17:15 +0000
From:   YUAN Linyu <Linyu.Yuan@...atel-sbell.com.cn>
To:     Chenbo Feng <chenbofeng.kernel@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>
CC:     Lorenzo Colitti <lorenzo@...gle.com>,
        Chenbo Feng <fengc@...gle.com>
Subject: RE: [PATCH net-next 2/2] bpf: Remove the capability check for
 cgroup skb eBPF program

hi

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
> On Behalf Of Chenbo Feng
> Sent: Thursday, June 01, 2017 2:07 AM
> To: netdev@...r.kernel.org; David Miller
> Cc: Lorenzo Colitti; Chenbo Feng
> Subject: [PATCH net-next 2/2] bpf: Remove the capability check for cgroup skb
> eBPF program
> -	if (type != BPF_PROG_TYPE_SOCKET_FILTER
> && !capable(CAP_SYS_ADMIN))
> +	if (type != BPF_PROG_TYPE_SOCKET_FILTER
> +	    && type != BPF_PROG_TYPE_CGROUP_SKB
> +	    && !capable(CAP_SYS_ADMIN))

checkpatch.pl prefer put && at end of line

>  		return -EPERM;
> 
>  	/* plain bpf_prog allocation */
> --
> 2.7.4