netdev - Re: [net,V2] vxlan: fix use-after-free on deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170602.143005.1852140319389134982.davem@davemloft.net>
Date:   Fri, 02 Jun 2017 14:30:05 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     markb@...lanox.com
Cc:     jbenc@...hat.com, roid@...lanox.com, roopa@...ulusnetworks.com,
        netdev@...r.kernel.org
Subject: Re: [net,V2] vxlan: fix use-after-free on deletion

From: Mark Bloch <markb@...lanox.com>
Date: Fri,  2 Jun 2017 03:24:08 +0300

> Adding a vxlan interface to a socket isn't symmetrical, while adding
> is done in vxlan_open() the deletion is done in vxlan_dellink().
> This can cause a use-after-free error when we close the vxlan
> interface before deleting it.
> 
> We add vxlan_vs_del_dev() to match vxlan_vs_add_dev() and call
> it from vxlan_stop() to match the call from vxlan_open().
> 
> Fixes: 56ef9c909b40 ("vxlan: Move socket initialization to within rtnl scope")
> Acked-by: Jiri Benc <jbenc@...hat.com>
> Tested-by: Roi Dayan <roid@...lanox.com>
> Signed-off-by: Mark Bloch <markb@...lanox.com>
> ---
> V2: Added a Fixes tag.
>     Added Acked-by and Tested-by from Jiri and Roi.

Applied and queued up for -stable, thanks.