netdev - Re: [PATCH net-next] net: phy: smsc: Implement PHY statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170603005243.GA3243@lunn.ch>
Date:   Sat, 3 Jun 2017 02:52:43 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Woojung.Huh@...rochip.com
Cc:     davem@...emloft.net, vivien.didelot@...oirfairelinux.com,
        cphealy@...il.com, nikita.yoush@...entembedded.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: smsc: Implement PHY statistics

Hi Woojung

> Just cosmetic thing.
> How about aligning with other members in structure like

Yes, i can do that. v2 tomorrow sometime.

> > +	.get_sset_count = smsc_get_sset_count,
> > +	.get_strings     = smsc_get_strings,
> > +	.get_stats        = smsc_get_stats,
> 
> Reviewed-By: Woojung Huh <Woojung.Huh@...rochip.com>

Thanks.

Can you confirm the LAN911x Internal PHY don't have this. The register
is not listed in the switch datasheet.

Thanks
	Andrew