netdev - Re: [PATCH net] sock: reset sk_err when the error queue is empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170604.200245.1799631200856186565.davem@davemloft.net>
Date:   Sun, 04 Jun 2017 20:02:45 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     soheil.kdev@...il.com
Cc:     netdev@...r.kernel.org, chrubis@...e.cz, soheil@...gle.com,
        edumazet@...gle.com, willemb@...gle.com
Subject: Re: [PATCH net] sock: reset sk_err when the error queue is empty

From: Soheil Hassas Yeganeh <soheil.kdev@...il.com>
Date: Fri,  2 Jun 2017 12:38:22 -0400

> From: Soheil Hassas Yeganeh <soheil@...gle.com>
> 
> Prior to f5f99309fa74 (sock: do not set sk_err in
> sock_dequeue_err_skb), sk_err was reset to the error of
> the skb on the head of the error queue.
> 
> Applications, most notably ping, are relying on this
> behavior to reset sk_err for ICMP packets.
> 
> Set sk_err to the ICMP error when there is an ICMP packet
> at the head of the error queue.
> 
> Fixes: f5f99309fa74 (sock: do not set sk_err in sock_dequeue_err_skb)
> Reported-by: Cyril Hrubis <chrubis@...e.cz>
> Test-by: Cyril Hrubis <chrubis@...e.cz>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied and queued up for -stable, thank you.