netdev - Re: [PATCH] net: ethoc: enable NAPI before poll may be scheduled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2017 07:26:20 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Max Filippov <jcmvbkbc@...il.com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Thierry Reding <thierry.reding@...il.com>,
        Tobias Klauser <tklauser@...tanz.ch>, stable@...r.kernel.org
Subject: Re: [PATCH] net: ethoc: enable NAPI before poll may be scheduled



On 06/05/2017 06:31 PM, Max Filippov wrote:
> ethoc_reset enables device interrupts, ethoc_interrupt may schedule a
> NAPI poll before NAPI is enabled in the ethoc_open, which results in
> device being unable to send or receive anything until it's closed and
> reopened. In case the device is flooded with ingress packets it may be
> unable to recover at all.
> Move napi_enable above ethoc_reset in the ethoc_open to fix that.
> 
> Cc: stable@...r.kernel.org
> Signed-off-by: Max Filippov <jcmvbkbc@...il.com>

Fixes: a1702857724f ("net: Add support for the OpenCores 10/100 Mbps
Ethernet MAC.")

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian