netdev - Re: [PATCH net-next] tcp: add TCPMemoryPressuresChrono counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170607.145448.152856288455996460.davem@davemloft.net>
Date:   Wed, 07 Jun 2017 14:54:48 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: add TCPMemoryPressuresChrono counter

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 06 Jun 2017 12:19:27 -0700

> @@ -320,18 +320,37 @@ struct tcp_splice_state {
>   * All the __sk_mem_schedule() is of this nature: accounting
>   * is strict, actions are advisory and have some latency.
>   */
> -int tcp_memory_pressure __read_mostly;
> +unsigned long tcp_memory_pressure __read_mostly;
>  EXPORT_SYMBOL(tcp_memory_pressure);

I know it is not strictly related to your change, but if you are
adding new exports in this area let's do it properly.

The existing tcp_memory_pressure export, as well as these two:

...
>  EXPORT_SYMBOL(tcp_enter_memory_pressure);
...
> +EXPORT_SYMBOL(tcp_leave_memory_pressure);

ought to be EXPORT_SYMBOL_GPL().  They are exported for the sake of
ipv6 TCP support, and nothing else.

I'll apply this with that fixed.

Thanks Eric.