netdev - Re: [PATCH net-next] net: ipmr: add getlink support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5793a3a8-8a7b-438c-a6b4-3c42271fe06d@cumulusnetworks.com>
Date:   Wed, 7 Jun 2017 10:44:38 +0300
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     netdev@...r.kernel.org
Cc:     roopa@...ulusnetworks.com, davem@...emloft.net,
        sharpd@...ulusnetworks.com
Subject: Re: [PATCH net-next] net: ipmr: add getlink support

On 06/06/17 19:41, Nikolay Aleksandrov wrote:
> Currently there's no way to dump the VIF table for an ipmr table other
> than the default (via proc). This is a major issue when debugging ipmr
> issues and in general it is good to know which interfaces are
> configured. This patch adds support for RTM_GETLINK for the ipmr family
> so we can dump the VIF table and the ipmr table's current config for
> each table. We're protected by rtnl so no need to acquire RCU or
> mrt_lock.
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> ---
> The plan is to add full netlink control to ipmr via new/set/dellink later.
> Also this would allow us to dump any number of VIFs in the future when we
> remove the VIF device limit.
> 
>  include/uapi/linux/mroute.h |  38 +++++++++++++++
>  net/ipv4/ipmr.c             | 114 ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 152 insertions(+)
> 

Self-NAK, after discussing this further with Roopa, I think it'll be best if we turn all of
these table and vif options into embedded separate netlink attributes. We'll get all the
netlink benefits and it will be much easier for user-space to manipulate them later.

Will send v2 later after some testing.

Thanks,
 Nik