netdev - Re: [PATCH net 3/3] ethtool.h: remind to update 802.3ad when adding new speeds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170608125635.GC78114@C02RW35GFVH8.dhcp.broadcom.net>
Date:   Thu, 8 Jun 2017 08:56:35 -0400
From:   Andy Gospodarek <andy@...yhouse.net>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, j.vosburgh@...il.com,
        vfalico@...il.com, thibaut.collet@...nd.com, linville@...driver.com
Subject: Re: [PATCH net 3/3] ethtool.h: remind to update 802.3ad when adding
 new speeds

On Thu, Jun 08, 2017 at 11:18:13AM +0200, Nicolas Dichtel wrote:
> Each time a new speed is added, the bonding 802.3ad isn't updated. Add a
> comment to remind the developer to update this driver.
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Acked-by: Andy Gospodarek <andy@...yhouse.net>

> ---
>  include/uapi/linux/ethtool.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
> index d179d7767f51..7d4a594d5d58 100644
> --- a/include/uapi/linux/ethtool.h
> +++ b/include/uapi/linux/ethtool.h
> @@ -1486,8 +1486,10 @@ enum ethtool_link_mode_bit_indices {
>   * it was forced up into this mode or autonegotiated.
>   */
>  
> -/* The forced speed, in units of 1Mb. All values 0 to INT_MAX are legal. */
> -/* Update drivers/net/phy/phy.c:phy_speed_to_str() when adding new values */
> +/* The forced speed, in units of 1Mb. All values 0 to INT_MAX are legal.
> + * Update drivers/net/phy/phy.c:phy_speed_to_str() and
> + * drivers/net/bonding/bond_3ad.c:__get_link_speed() when adding new values.

A little wide, but not wider than it was before, so that's fine with me.

> + */
>  #define SPEED_10		10
>  #define SPEED_100		100
>  #define SPEED_1000		1000
> -- 
> 2.8.1
>