netdev - Re: [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170608.091835.68093454960092119.davem@davemloft.net>
Date:   Thu, 08 Jun 2017 09:18:35 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     alexei.starovoitov@...il.com
Cc:     yanhaishuang@...s.chinamobile.com, netdev@...r.kernel.org,
        edumazet@...gle.com
Subject: Re: [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

From: Alexei Starovoitov <alexei.starovoitov@...il.com>
Date: Wed, 7 Jun 2017 22:00:43 -0700

> On Thu, Jun 08, 2017 at 12:56:58PM +0800, 严海双 wrote:
>> 
>> > On 8 Jun 2017, at 12:38 PM, Alexei Starovoitov <alexei.starovoitov@...il.com> wrote:
>> > 
>> > On Thu, Jun 08, 2017 at 12:32:44PM +0800, Haishuang Yan wrote:
>> >> When __ip6_tnl_rcv fails, the tun_dst won't be freed, so call
>> >> dst_release to free it in error code path.
>> >> 
>> >> CC: Alexei Starovoitov <ast@...com>
>> >> Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels")
>> >> Signed-off-by: Haishuang Yan <yanhaishuang@...s.chinamobile.com>
>> > 
>> > I don't get it. Why did you send another version of the patch?
>> > What was wrong with previous approach that myself and Eric acked?
>> > 
>> > 
>> 
>> Sorry for your confusing, because Pravin Shelar give a feedback in ipv4 patch, see below:
> 
> hmm. right.
> Then it raises the question: How did you test this and previous patch?
> 
> since previous version was sort-of fixing the bug, but completely
> breaking the logic...

Anyone who posts new patches this patch isn't testing things thoroughly at all.