netdev - Re: next-20170608 build: 1 failures 4 warnings (next-20170608)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170608.101627.1876505383531574064.davem@davemloft.net>
Date:   Thu, 08 Jun 2017 10:16:27 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     sfr@...b.auug.org.au
Cc:     netdev@...r.kernel.org, broonie@...nel.org,
        linaro-kernel@...ts.linaro.org, linux-next@...r.kernel.org
Subject: Re: next-20170608 build: 1 failures 4 warnings (next-20170608)

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Thu, 8 Jun 2017 20:27:04 +1000

> Hi Dave,
> 
> On Thu, 08 Jun 2017 10:57:50 +0100 Build bot for Mark Brown <broonie@...nel.org> wrote:
>>
>> Tree/Branch: next-20170608
>> Git describe: next-20170608
>> Commit: e4689b9aad Add linux-next specific files for 20170608
>> 
>> Build Time: 0 min 12 sec
>> 
>> Passed:    6 / 7   ( 85.71 %)
>> Failed:    1 / 7   ( 14.29 %)
>> 
>> Errors: 1
>> Warnings: 4
>> Section Mismatches: 0
>> 
>> Failed defconfigs:
>> 	arm-allmodconfig
>> 
>> Errors:
>> 
>> 	arm-allmodconfig
>> ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor'
> 
> Looks like Mark has found another one.

This should fix it, pushed out to 'net'.

Thanks.

====================
[PATCH] hsi: Fix build regression due to netdev destructor fix.

> ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has no member named 'destructor'

Reported-by: Mark Brown <broonie@...nel.org>
Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
Signed-off-by: David S. Miller <davem@...emloft.net>
---
 drivers/hsi/clients/ssi_protocol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
index 26b0510..93d28c0 100644
--- a/drivers/hsi/clients/ssi_protocol.c
+++ b/drivers/hsi/clients/ssi_protocol.c
@@ -1066,7 +1066,7 @@ static void ssip_pn_setup(struct net_device *dev)
 	dev->addr_len		= 1;
 	dev->tx_queue_len	= SSIP_TXQUEUE_LEN;
 
-	dev->destructor		= free_netdev;
+	dev->needs_free_netdev	= true;
 	dev->header_ops		= &phonet_header_ops;
 }
 
-- 
2.4.11