netdev - Re: [PATCH] net/ethtool: Replace memset with compiler directive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170608.102342.969656909338882182.davem@davemloft.net>
Date:   Thu, 08 Jun 2017 10:23:42 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     yuval.shaia@...cle.com
Cc:     andrew@...n.ch, allan.nielsen@...rosemi.com,
        Raju.Lakkaraju@...rosemi.com, jakub.kicinski@...ronome.com,
        steffen.klassert@...unet.com, ast@...com, sgruszka@...hat.com,
        mlichvar@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net/ethtool: Replace memset with compiler directive

From: Yuval Shaia <yuval.shaia@...cle.com>
Date: Thu,  8 Jun 2017 16:32:21 +0300

> Take advantage of compiler variable zero-ing and remove calls to memset.
> 
> Signed-off-by: Yuval Shaia <yuval.shaia@...cle.com>

That construct looks so ugly, also the memset()'s in some cases are
constrained to the basic blockwhere the variable is used, avoiding an
initialization unnecessarily.

I'm not applying this, sorry.