netdev - Re: [PATCH 2/5] net: mvpp2: use {get,put}_cpu() instead of smp_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e81a0c75-7ae2-a656-6c45-74d8694d358f@arm.com>
Date:   Thu, 8 Jun 2017 17:01:36 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Marcin Wojtas <mw@...ihalf.com>,
        Stefan Chulski <stefanc@...vell.com>,
        Nadav Haklai <nadavh@...vell.com>,
        Hanna Hawa <hannah@...vell.com>,
        Yehuda Yitschak <yehuday@...vell.com>,
        Antoine Tenart <antoine.tenart@...e-electrons.com>,
        Gregory Clement <gregory.clement@...e-electrons.com>,
        Markus Elfring <elfring@...rs.sourceforge.net>
Subject: Re: [PATCH 2/5] net: mvpp2: use {get,put}_cpu() instead of
 smp_processor_id()

On 08/06/17 16:27, Thomas Petazzoni wrote:
> smp_processor_id() should not be used in migration-enabled contexts. We
> originally thought it was OK in the specific situation of this driver,
> but it was wrong, and calling smp_processor_id() in a migration-enabled
> context prints a big fat warning when CONFIG_DEBUG_PREEMPT=y.
> 
> Therefore, this commit replaces the smp_processor_id() in
> migration-enabled contexts by the appropriate get_cpu/put_cpu sections.
> 
> Reported-by: Marc Zyngier <marc.zyngier@....com>
> Fixes: a786841df72e ("net: mvpp2: handle register mapping and access for PPv2.2")
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>

Tested-by: Marc Zyngier <marc.zyngier@....com>

	M.
-- 
Jazz is not dead. It just smells funny...