netdev - Re: [patch net-next v2 00/19] Remove support from bridge bypass for mlxsw/rocker drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170608.141703.1743511775233597085.davem@davemloft.net>
Date:   Thu, 08 Jun 2017 14:17:03 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, idosch@...lanox.com, arkadis@...lanox.com,
        mlxsw@...lanox.com, roopa@...ulusnetworks.com,
        stephen@...workplumber.org, ivecera@...hat.com,
        nikolay@...ulusnetworks.com
Subject: Re: [patch net-next v2 00/19] Remove support from bridge bypass
 for mlxsw/rocker drivers

From: Jiri Pirko <jiri@...nulli.us>
Date: Thu,  8 Jun 2017 08:44:09 +0200

> Currently setting bridge port attributes and adding FDBs are done via
> setting the SELF flag which implies unconsistent offloading model. This
> patch-set fixes this behavior by making the bridge and drivers which are
> using it to be totally in sync.
> 
> This implies several changes:
> - Offloading bridge flags from the bridge code.
> - Sending notification about FDB add/del to the software bridge in a 
>   similiar way it is done for the hardware externally learned FDBs.
> 
> By making the offloading model more consistent a cleanup is done in
> the drivers supporting it. This is done in order to remove un-needed
> logic related to dump operation which is redundant.
> 
> First add missing functionality to bridge, then clean up the mlxsw/rocker
> drivers.
> ---
> v1->v2
> - Move bridge-switchdev related stuff to br_switchdev.c as suggested by Nik

Series applied.

I really appreciate how you split these changes up to make them easier
to review.

Thanks.