netdev - Re: [PATCH net-next 5/7] net: dsa: mv88e6xxx: rework pause limit operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170608194054.GI20216@lunn.ch>
Date:   Thu, 8 Jun 2017 21:40:54 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...oirfairelinux.com,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next 5/7] net: dsa: mv88e6xxx: rework pause limit
 operation

On Thu, Jun 08, 2017 at 03:04:43PM -0400, Vivien Didelot wrote:
> All Marvell chips supporting Pause frames limiting use 1-byte value for
> input and output.
> 
> Old chips have both bytes adjacent in a 16-bit register. New ones have
> an indirect table using 8-bit data.
> 
> The mv88e6xxx library functions (such as in port.c) must not contain
> driver logic, but only generic helpers. This patch changes the
> port_pause_config operation for port_pause_limit taking two u8 arguments
> for input and output limits. There is no functional changes.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew