netdev - Re: [PATCH net] openvswitch: warn about missing first netlink attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 08 Jun 2017 15:57:33 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     nicolas.dichtel@...nd.com
Cc:     netdev@...r.kernel.org, pshelar@...ira.com, dev@...nvswitch.org
Subject: Re: [PATCH net] openvswitch: warn about missing first netlink
 attribute

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Thu,  8 Jun 2017 10:37:45 +0200

> The first netlink attribute (value 0) must always be defined
> as none/unspec.
> 
> Because we cannot change an existing UAPI, I add a comment to point the
> mistake and avoid to propagate it in a new ovs API in the future.
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Ok, I agree, we don't want people cut-and-pasting this kind of thing
and hopefully this comment prevents that.

Applied, thanks.