netdev - Re: [PATCH v2 1/2] ip_tunnel: fix potential issue in ip_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1496888480.736.51.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Wed, 07 Jun 2017 19:21:20 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Haishuang Yan <yanhaishuang@...s.chinamobile.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Pravin B Shelar <pshelar@...ira.com>,
        Haishuang Yan <yanhaishuang@...s.chinamobile.com390e>
Subject: Re: [PATCH v2 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv

On Thu, 2017-06-08 at 08:57 +0800, Haishuang Yan wrote:
> When ip_tunnel_rcv fails, the tun_dst won't be freed, so move
> skb_dst_set to begin and tun_dst would be freed by kfree_skb.
> 
> CC: Pravin B Shelar <pshelar@...ira.com>
> Fixes: 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.")
> Signed-off-by: Haishuang Yan <yanhaishuang@...s.chinamobile.com390e>
> ---

Acked-by: Eric Dumazet <edumazet@...gle.com>

Thanks a lot.