netdev - Re: [patch net-next v2 02/19] net: bridge: Add support for offloading port attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c6b5e2b-b777-f11e-adee-aaa7435a78bd@cumulusnetworks.com>
Date:   Thu, 8 Jun 2017 12:24:09 +0300
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, idosch@...lanox.com, arkadis@...lanox.com,
        mlxsw@...lanox.com, roopa@...ulusnetworks.com,
        stephen@...workplumber.org, ivecera@...hat.com
Subject: Re: [patch net-next v2 02/19] net: bridge: Add support for offloading
 port attributes

On 08/06/17 09:44, Jiri Pirko wrote:
> From: Arkadi Sharshevsky <arkadis@...lanox.com>
> 
> Currently the flood, learning and learning_sync port attributes are
> offloaded by setting the SELF flag. Add support for offloading the
> flood and learning attribute through the bridge code. In case of
> setting an unsupported flag on a offloded port the operation will
> fail.
> 
> The learning_sync attribute doesn't have any software representation
> and cannot be offloaded through the bridge code.
> 
> Signed-off-by: Arkadi Sharshevsky <arkadis@...lanox.com>
> Reviewed-by: Ido Schimmel <idosch@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> ---
>  net/bridge/br_netlink.c   | 87 +++++++++++++++++++++++++++++++++++------------
>  net/bridge/br_private.h   | 10 ++++++
>  net/bridge/br_switchdev.c | 43 +++++++++++++++++++++++
>  3 files changed, 119 insertions(+), 21 deletions(-)
> 

LGTM, thanks!

Reviewed-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>