netdev - Re: [PATCH] sh_eth: add support to change MTU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15374026-bf82-5b4c-7d1a-53b21dff3451@cogentembedded.com>
Date:   Fri, 9 Jun 2017 19:31:09 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>
Cc:     netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH] sh_eth: add support to change MTU

Hello!

On 06/09/2017 06:30 PM, Niklas Söderlund wrote:

> The hardware supports the MTU to be changed and the driver it self is
> somewhat prepared to support this. This patch hooks up the callbacks to
> be able to change the MTU from user-space.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
[...]

    One more thing off my back, thanks! :-)
    I'm OK with this patch in principle (but have several nits):

Acked-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index f68c4db656eda846..da41eda7bfada6b9 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
[...]
> @@ -3171,6 +3184,13 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
>  	}
>  	sh_eth_set_default_cpu_data(mdp->cd);
>
> +	/* Datasheet states max MTU should be 2048 but due to the

    User's manual. :-)
    Somehow I thought it supports jumbo frames but the manual doesn't confirm 
that... ah, that's EtherAVB! :-)

> +	 * aliment calculations in sh_eth_ring_init() the practical

   Alignment.

> +	 * MTU is a bit less. Maybe this can be optimized some more.

    Undoubtedly... :-)

[...]

MBR, Sergei