lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 Jun 2017 16:43:59 +0800 From: Xin Long <lucien.xin@...il.com> To: Steffen Klassert <steffen.klassert@...unet.com> Cc: Hangbin Liu <liuhangbin@...il.com>, David Miller <davem@...emloft.net>, network dev <netdev@...r.kernel.org> Subject: Re: [PATCH net] net/flow: fix fc->percpu NULL pointer dereference On Fri, Jun 9, 2017 at 4:32 PM, Steffen Klassert <steffen.klassert@...unet.com> wrote: > On Fri, Jun 09, 2017 at 04:23:01PM +0800, Hangbin Liu wrote: >> Hi Steffen, >> >> BTW, If we put the check in xfrm_policy_flush(), we can prevent it earlier. >> But If we put the check in flow_cache_percpu_empty(), we can prevent >> other functions set fc->percpu to NULL, although not much possible : ) >> >> So I'm not quite sure whether we should put the check in >> flow_cache_percpu_empty() or in xfrm_policy_flush(). > > Can't we just call xfrm_policy_fini() first and then flow_cache_fini()? > That would be a better fix. seems safe as what flow_cache_fini does is only to free fcp->hash_table and stop timer, I didn't see it has any dependence on xfrm_policy stuff.
Powered by blists - more mailing lists