netdev - Re: [PATCH net-next 3/6] netvsc: use typed pointer for internal state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a26be48a-b3c8-484c-5415-f13aeee34d02@cogentembedded.com>
Date:   Fri, 9 Jun 2017 13:24:24 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Stephen Hemminger <stephen@...workplumber.org>, kys@...rosoft.com,
        haiyangz@...rosoft.com, sthemmin@...rosoft.com
Cc:     devel@...uxdriverproject.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/6] netvsc: use typed pointer for internal state

Hello.

On 6/9/2017 2:21 AM, Stephen Hemminger wrote:

> The element netvsc_device:extension is always a point to RNDIS

    Pointer, maybe?

> information.
>
> Signed-off-by: Stephen Hemminger <sthemmin@...rosoft.com>
> ---
>  drivers/net/hyperv/hyperv_net.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
> index 262b2ea576a3..f82d54e0208c 100644
> --- a/drivers/net/hyperv/hyperv_net.h
> +++ b/drivers/net/hyperv/hyperv_net.h
> @@ -763,8 +763,7 @@ struct netvsc_device {
>
>  	refcount_t sc_offered;
>
> -	/* Holds rndis device info */
> -	void *extension;
> +	struct rndis_device *extension;
>
>  	int ring_size;
>

MBR, Sergei