netdev - Re: [PATCH net v3] net: ipmr: Fix some mroute forwarding issues in vrf's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1497137970727.29475@alliedtelesis.co.nz>
Date:   Sat, 10 Jun 2017 23:39:42 +0000
From:   Thomas Winter <Thomas.Winter@...iedtelesis.co.nz>
To:     David Ahern <dsahern@...il.com>,
        David Miller <davem@...emloft.net>,
        "sharpd@...ulusnetworks.com" <sharpd@...ulusnetworks.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nikolay@...ulusnetworks.com" <nikolay@...ulusnetworks.com>,
        "yotamg@...lanox.com" <yotamg@...lanox.com>,
        "idosch@...lanox.com" <idosch@...lanox.com>,
        "roopa@...ulusnetworks.com" <roopa@...ulusnetworks.com>
Subject: Re: [PATCH net v3] net: ipmr: Fix some mroute forwarding issues in
 vrf's

I don't think we've seen this issue but patch looks good.
________________________________________
From: David Ahern <dsahern@...il.com>
Sent: 11 June 2017 11:33
To: David Miller; sharpd@...ulusnetworks.com
Cc: netdev@...r.kernel.org; Thomas Winter; nikolay@...ulusnetworks.com; yotamg@...lanox.com; idosch@...lanox.com; roopa@...ulusnetworks.com
Subject: Re: [PATCH net v3] net: ipmr: Fix some mroute forwarding issues in vrf's

On 6/10/17 5:07 PM, David Miller wrote:
> From: Donald Sharp <sharpd@...ulusnetworks.com>
> Date: Sat, 10 Jun 2017 16:30:17 -0400
>
>> This patch fixes two issues:
>>
>> 1) When forwarding on *,G mroutes that are in a vrf, the
>> kernel was dropping information about the actual incoming
>> interface when calling ip_mr_forward from ip_mr_input.
>> This caused ip_mr_forward to send the multicast packet
>> back out the incoming interface.  Fix this by
>> modifying ip_mr_forward to be handed the correctly
>> resolved dev.
>>
>> 2) When a unresolved cache entry is created we store
>> the incoming skb on the unresolved cache entry and
>> upon mroute resolution from the user space daemon,
>> we attempt to forward the packet.  Again we were
>> not resolving to the correct incoming device for
>> a vrf scenario, before calling ip_mr_forward.
>> Fix this by resolving to the correct interface
>> and calling ip_mr_forward with the result.
>>
>> Fixes: e58e41596811 ("net: Enable support for VRF with ipv4 multicast")
>> Signed-off-by: Donald Sharp <sharpd@...ulusnetworks.com>
>
> David, please review.
>

Responded. Would be good for the Mellanox team (and Thomas) to chime in
as well.