netdev - Re: [PATCH v2] sh_eth: add support to change MTU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <239c39ff-cf0e-d332-7b52-098ba8029798@cogentembedded.com>
Date:   Sat, 10 Jun 2017 22:26:13 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Niklas Söderlund <niklas.soderlund@...natech.se>
Cc:     netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v2] sh_eth: add support to change MTU

Hello!

On 06/09/2017 11:36 PM, Niklas Söderlund wrote:

>> The hardware supports the MTU to be changed and the driver it self is
>> somewhat prepared to support this. This patch hooks up the callbacks to
>> be able to change the MTU from user-space.
>>
>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
>> Acked-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>> ---
[...]
>> @@ -3171,6 +3184,13 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
>>  	}
>>  	sh_eth_set_default_cpu_data(mdp->cd);
>>
>> +	/* User's manua states max MTU should be 2048 but due to the
>
> s/manua/manual/

    Looking at it for another time, I'd also reword the subject -- something 
like "sh_eth: add support for changing MTU" or "sh_eth: add MTU change support".

MBR, Sergei