netdev - Re: [PATCH net-next 1/1] net: reflect mark on tcp syn ack packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <056cbd5c-2a5f-8767-e584-591f39bc2029@mojatatu.com>
Date:   Sun, 11 Jun 2017 07:58:18 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     davem@...emloft.net
Cc:     netdev@...r.kernel.org, lorenzo@...gle.com, mrv@...atatu.com,
        hadi@...atatu.com
Subject: Re: [PATCH net-next 1/1] net: reflect mark on tcp syn ack packets

On 17-06-10 07:02 PM, David Miller wrote:

>> @@ -173,7 +173,8 @@ int ip_build_and_send_pkt(struct sk_buff *skb, const struct sock *sk,
>>   	}
>>   
>>   	skb->priority = sk->sk_priority;
>> -	skb->mark = sk->sk_mark;
>> +	if (!skb->mark)
>> +		skb->mark = sk->sk_mark;
> 
> Maybe this should both be "inet_request_mark()"?
> 

Challenge is making of a synack requires a new allocated skb;
and sk is a listening socket - which should/has a mark of
0 meaning at ip_build_and_send_pkt() it overrides
the value already set on the skb->mark.

cheers,
jamal

> Also, Lorenzo, please review.
>