lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 11 Jun 2017 16:49:50 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Arend van Spriel <arend.vanspriel@...adcom.com> Cc: "Peter S. Housel" <housel@....org>, Franky Lin <franky.lin@...adcom.com>, Hante Meuleman <hante.meuleman@...adcom.com>, Kalle Valo <kvalo@...eaurora.org>, Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com>, Christian Daudt <csd@...adcom.com>, Florian Fainelli <f.fainelli@...il.com>, Florian Westphal <fw@...len.de>, Martin Blumenstingl <martin.blumenstingl@...glemail.com>, "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" <linux-wireless@...r.kernel.org>, "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" <brcm80211-dev-list.pdl@...adcom.com>, "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] brcmfmac: Fix glom_skb leak in brcmf_sdiod_recv_chain On Sat, Jun 10, 2017 at 10:27 PM, Arend van Spriel <arend.vanspriel@...adcom.com> wrote: > On 03-06-17 17:36, Andy Shevchenko wrote: >> On Sat, Jun 3, 2017 at 1:29 AM, Peter S. Housel <housel@....org> wrote: The following looks good to me. Feel free to add Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com> > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c > @@ -705,7 +705,7 @@ int brcmf_sdiod_recv_pkt(struct brcmf_sdio_dev > *sdiodev, struct sk_buff *pkt) > int brcmf_sdiod_recv_chain(struct brcmf_sdio_dev *sdiodev, > struct sk_buff_head *pktq, uint totlen) > { > - struct sk_buff *glom_skb; > + struct sk_buff *glom_skb = NULL; > struct sk_buff *skb; > u32 addr = sdiodev->sbwad; > int err = 0; > @@ -726,10 +726,8 @@ int brcmf_sdiod_recv_chain(struct brcmf_sdio_dev > *sdiodev, > return -ENOMEM; > err = brcmf_sdiod_buffrw(sdiodev, SDIO_FUNC_2, false, addr, > glom_skb); > - if (err) { > - brcmu_pkt_buf_free_skb(glom_skb); > + if (err) > goto done; > - } > > skb_queue_walk(pktq, skb) { > memcpy(skb->data, glom_skb->data, skb->len); > @@ -740,6 +738,7 @@ int brcmf_sdiod_recv_chain(struct brcmf_sdio_dev > *sdiodev, > pktq); > > done: > + brcmu_pkt_buf_free_skb(glom_skb); > return err; > } > -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists