netdev - Re: [PATCH net-next] vxlan: dont migrate permanent fdb entries during learn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJieiUis6KOeLX-ePVbDd5U=ePXonvnAcFo0zkL__aQasjHrmg@mail.gmail.com>
Date:   Sun, 11 Jun 2017 16:26:31 -0700
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     David Miller <davem@...emloft.net>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Benc <jbenc@...hat.com>,
        "hannes@...essinduktion.org" <hannes@...essinduktion.org>,
        Nicolas Dichtel <nicolas.dichtel@...nd.com>,
        Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Subject: Re: [PATCH net-next] vxlan: dont migrate permanent fdb entries during learn

On Sun, Jun 11, 2017 at 4:04 PM, David Miller <davem@...emloft.net> wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> Date: Sun, 11 Jun 2017 15:51:22 -0700
>
>> From: Roopa Prabhu <roopa@...ulusnetworks.com>
>>
>> This patch fixes vxlan_snoop to not move permanent fdb entries
>> on learn events. This is consistent with the bridge fdb
>> handling of permanent entries.
>>
>> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
>
> Is there an appropriate Fixes: tag by chance?

Just checked history. It has been that way since beginning of time.
Initial vxlan implementation (year 2012) allowed migration of any
entry via learn. A 2013 commit 26a41ae60438 ("vxlan: only migrate
dynamic FDB entries") tried to fix it, but it added a check for static
entries only (NUD_NOARP) and missed permanent entries (NUD_PERMANENT).

I think we can add:
Fixes: 26a41ae60438 ("vxlan: only migrate dynamic FDB entries")

I can re-spin with this Fixes tag.