netdev - Re: [net v1 PATCH] hsr: fix incorrect warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Jun 2017 15:22:47 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     m-karicheri2@...com
Cc:     arvid.brodin@...en.se, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [net v1 PATCH] hsr: fix incorrect warning

From: Murali Karicheri <m-karicheri2@...com>
Date: Mon, 12 Jun 2017 15:06:26 -0400

> When HSR interface is setup using ip link command, an annoying warning
> appears with the trace as below:-
> 
> [  203.019828] hsr_get_node: Non-HSR frame
> [  203.019833] Modules linked in:
> [  203.019848] CPU: 0 PID: 158 Comm: sd-resolve Tainted: G        W       4.12.0-rc3-00052-g9fa6bf70 #2
> [  203.019853] Hardware name: Generic DRA74X (Flattened Device Tree)
> [  203.019869] [<c0110280>] (unwind_backtrace) from [<c010c2f4>] (show_stack+0x10/0x14)
> [  203.019880] [<c010c2f4>] (show_stack) from [<c04b9f64>] (dump_stack+0xac/0xe0)
> [  203.019894] [<c04b9f64>] (dump_stack) from [<c01374e8>] (__warn+0xd8/0x104)
> [  203.019907] [<c01374e8>] (__warn) from [<c0137548>] (warn_slowpath_fmt+0x34/0x44)
> root@...7xx-evm:~# [  203.019921] [<c0137548>] (warn_slowpath_fmt) from [<c081126c>] (hsr_get_node+0x148/0x170)
> [  203.019932] [<c081126c>] (hsr_get_node) from [<c0814240>] (hsr_forward_skb+0x110/0x7c0)
> [  203.019942] [<c0814240>] (hsr_forward_skb) from [<c0811d64>] (hsr_dev_xmit+0x2c/0x34)
> [  203.019954] [<c0811d64>] (hsr_dev_xmit) from [<c06c0828>] (dev_hard_start_xmit+0xc4/0x3bc)
> [  203.019963] [<c06c0828>] (dev_hard_start_xmit) from [<c06c13d8>] (__dev_queue_xmit+0x7c4/0x98c)
> [  203.019974] [<c06c13d8>] (__dev_queue_xmit) from [<c0782f54>] (ip6_finish_output2+0x330/0xc1c)
> [  203.019983] [<c0782f54>] (ip6_finish_output2) from [<c0788f0c>] (ip6_output+0x58/0x454)
> [  203.019994] [<c0788f0c>] (ip6_output) from [<c07b16cc>] (mld_sendpack+0x420/0x744)
> 
> As this is an expected path to hsr_get_node() with frame coming from
> the master interface, add a check to ensure packet is not from the
> master port and then warn.
> 
> Signed-off-by: Murali Karicheri <m-karicheri2@...com>

Applied, thank you.