netdev - Re: [PATCH v2] net: phy: Make phy_ethtool_ksettings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170612.105905.1031273319008486521.davem@davemloft.net>
Date:   Mon, 12 Jun 2017 10:59:05 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     yuval.shaia@...cle.com
Cc:     michael.chan@...adcom.com, f.fainelli@...il.com,
        siva.kallam@...adcom.com, prashant@...adcom.com,
        madalin.bucur@....com, leoli@...escale.com,
        sebastian.hesselbarth@...il.com,
        sergei.shtylyov@...entembedded.com, grygorii.strashko@...com,
        w-kwok2@...com, m-karicheri2@...com, andrew@...n.ch,
        woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        vivien.didelot@...oirfairelinux.com, arnd@...db.de,
        tremyfr@...il.com, jarod@...hat.com, horms+renesas@...ge.net.au,
        kazuya.mizuguchi.ks@...esas.com, dan.carpenter@...cle.com,
        niklas.soderlund+renesas@...natech.se, johan@...nel.org,
        masaru.nagai.vx@...esas.com, geert+renesas@...der.be,
        laurent.pinchart@...asonboard.com, chris.brandt@...esas.com,
        ivan.khoronzhuk@...aro.org, mugunthanvnm@...com,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linuxppc-dev@...ts.ozlabs.org, linux-renesas-soc@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void

From: David Miller <davem@...emloft.net>
Date: Mon, 12 Jun 2017 10:25:25 -0400 (EDT)

> From: Yuval Shaia <yuval.shaia@...cle.com>
> Date: Mon, 12 Jun 2017 17:15:08 +0300
> 
>> Make return value void since function never return meaningfull value
>> 
>> Signed-off-by: Yuval Shaia <yuval.shaia@...cle.com>
>> Acked-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>> ---
>> v0 ->v1:
>> 	* These files were missing in v0
>> 		* drivers/net/ethernet/renesas/ravb_main.c
>> 		* drivers/net/ethernet/renesas/sh_eth.c
>> 		* drivers/net/ethernet/ti/netcp_ethss.c
>> 	* Add Acked-by: Sergei Shtylyov
>> v1 -> v2:
>> 	* Adjust to net-next tree
> 
> Applied, thank you.

Reverted, please test your build properly:

drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c: In function ‘xgene_get_link_ksettings’:
drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c:134:10: error: void value not ignored as it ought to be
   return phy_ethtool_ksettings_get(phydev, cmd);
          ^
drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c:140:11: error: void value not ignored as it ought to be
    return phy_ethtool_ksettings_get(phydev, cmd);
           ^
scripts/Makefile.build:302: recipe for target 'drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.o' failed